Skip to content

Add multi-folder checkbox to list designer advanced settings #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Dec 24, 2024

Rationale

Limit PHI annotations to single container tables

Related Pull Requests

Changes

  • Add "Multi-folder" checkbox to advanced settings dialog. Save and load it.
  • Switch server-supplied supportsPhiLevel property to phiLevelEnabled and update client to use it to disable/enable the PHI level drop-down list as appropriate
  • If PHI Level drop-down is disabled, provide phiLevelDisabledReason in tooltip
  • Update view template XML to use <requiresPermissions>. <permissionClasses> is still supported, but <requiresPermissions> is preferred.

@labkey-adam labkey-adam changed the title Add multi-folder advanced setting to list designer Add multi-folder checkbox to list designer advanced settings Dec 24, 2024
@labkey-adam labkey-adam marked this pull request as draft January 6, 2025 23:17
@labkey-adam labkey-adam requested a review from cnathe January 6, 2025 23:17
Copy link
Contributor

@cnathe cnathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one requested change about removing the unused props from that DEFAULT_DOMAIN_FORM_DISPLAY_OPTIONS const.

Also, I was going to pull this down and try it, but I didn't see the related platform fb. Also, did you just test with start-link? If so, it would be good to publish an alpha package version and then put that into the core/package.json so that you can build and try it in your platform fb. Let me know if you need help with those steps.

@cnathe
Copy link
Contributor

cnathe commented Jan 7, 2025

note that the steps for publishing an alpha package version are here:
https://github.com/LabKey/labkey-ui-components/blob/develop/packages/components/docs/localDev.md#steps

@labkey-adam
Copy link
Contributor Author

Looks good, just the one requested change about removing the unused props from that DEFAULT_DOMAIN_FORM_DISPLAY_OPTIONS const.

Also, I was going to pull this down and try it, but I didn't see the related platform fb. Also, did you just test with start-link? If so, it would be good to publish an alpha package version and then put that into the core/package.json so that you can build and try it in your platform fb. Let me know if you need help with those steps.

Right, I haven't created the platform PR nor published an alpha yet. I wanted to get a bit of feedback first. I'll make it all available tomorrow. Note that the platform PR has an upgrade script and is still a WIP, so you'll have to endure some schema version complaints if you switch back to develop or FB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants