-
Notifications
You must be signed in to change notification settings - Fork 2
Add multi-folder checkbox to list designer advanced settings #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…rovide disabled reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the one requested change about removing the unused props from that DEFAULT_DOMAIN_FORM_DISPLAY_OPTIONS
const.
Also, I was going to pull this down and try it, but I didn't see the related platform fb. Also, did you just test with start-link? If so, it would be good to publish an alpha package version and then put that into the core/package.json so that you can build and try it in your platform fb. Let me know if you need help with those steps.
packages/components/src/internal/components/domainproperties/constants.ts
Outdated
Show resolved
Hide resolved
note that the steps for publishing an alpha package version are here: |
Right, I haven't created the platform PR nor published an alpha yet. I wanted to get a bit of feedback first. I'll make it all available tomorrow. Note that the platform PR has an upgrade script and is still a WIP, so you'll have to endure some schema version complaints if you switch back to develop or FB. |
Rationale
Limit PHI annotations to single container tables
Related Pull Requests
Changes
supportsPhiLevel
property tophiLevelEnabled
and update client to use it to disable/enable the PHI level drop-down list as appropriatephiLevelDisabledReason
in tooltip<requiresPermissions>
.<permissionClasses>
is still supported, but<requiresPermissions>
is preferred.