-
Notifications
You must be signed in to change notification settings - Fork 6
Add khiops-env to conda packages #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bruno-at-orange
merged 5 commits into
dev
from
258-provide-the-khiops-env-script-for-all-packages
Sep 30, 2024
Merged
Add khiops-env to conda packages #343
bruno-at-orange
merged 5 commits into
dev
from
258-provide-the-khiops-env-script-for-all-packages
Sep 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
875233b
to
d490460
Compare
0acec33
to
bed62a6
Compare
bc5fe99
to
6b2c249
Compare
49a22ce
to
4f4759d
Compare
popescu-v
reviewed
Sep 26, 2024
255f7b6
to
f001e74
Compare
popescu-v
reviewed
Sep 27, 2024
popescu-v
reviewed
Sep 27, 2024
05b8af7
to
fc06c05
Compare
Add a new tiny binary to show the physical core number. It is only used by khiops_env. This binary is packaged with khiops, so there is an impact on conda, deb, rpm and NSIS.
fc06c05
to
9447868
Compare
Add KHIOPS_MPI_HOST_FILE to khiops_env - Allows to specify a hostfile to mpiexec - if this variable is defined, khiops_env will export environment variables required by khiops to run correctly to MPI processes. These variables relate to GCS/S3 credentials and to khiops itself (KHIOPS_* and Khiops*) khiops_env is built on cmake configure: the variable export is done only for openmpi and the hostfile keyword is different for openmpi and mpich Remove process affinity for MS-MPI - As discussed in #350, the affinity slows down khiops. - remove the prioryty (below normal) too Improve UNIXes khiops_env - java configuration and modules loading are not in khiops_env on conda environment - To improve the install.cmake readability, 3 files are added to fill variables: - export_env_variables.sh - java_settings.sh - use_environment_module.sh fix GUI error message in khiops and khiops coclustering - The message saying to install "khiops" on conda environment is wrong. - when a non-existing option is passed, e.g. khiops --foo, the GUI message is displayed fix message in help about KHIOPS_API_MODE: false <=> true KHIOPS_API_MODE message
bug fix: when running tests without using kht_test, we have to set the variable KHIOPS_API_MODE to true
9447868
to
be2aa9c
Compare
popescu-v
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
bruno-at-orange
added a commit
that referenced
this pull request
Oct 1, 2024
Update of the khiops_env script on Linux/Mac and Windows to be compatible with conda environments (even without CONDA_PREFIX). Conda packages are updated with khiops_env (on all OS). It has an impact on packaging (cmake, NSIS) and github actions. Add a new variable KHIOPS_MPI_HOST_FILE (in Linux only) to set up the MPI command line on multi-machines Remove process affinity on windows backport #343 from dev
Merged
thekester
pushed a commit
to thekester/khiops
that referenced
this pull request
Mar 22, 2025
…env-script-for-all-packages Add khiops-env to conda packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the khiops_env script on Linux/Mac and Windows to be compatible with conda environments (even without CONDA_PREFIX). Conda packages are updated with khiops_env (on all OS). It has an impact on packaging (cmake, NSIS) and github actions.
The important comments are in commit a98e684
Add a new variable KHIOPS_MPI_HOST_FILE (in Linux only) to set up the MPI command line on multi-machines
Remove process affinity on windows
close #225