OpenMPI path issue with khiops 10.2.2 on Debian-like OS #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tramora opened this issue Jul 9, 2024 · 5 comments · Fixed by #218

Assignees

Labels

Milestone

Collaborator

tramora commented Jul 9, 2024 •

edited by folmos-at-orange

Loading

Description

When using khiops-python API, the following command line is eventually executed :

/bin/mpiexec --allow-run-as-root --quiet -n 14 /usr/bin/MODL -b -i train_predictor_XXX._kh -e khiops.log

With openmpi installed with this 10.2.2-1 version it fails :

--------------------------------------------------------------------------
A prefix was supplied to mpiexec that only contained slashes.

This is a fatal error; mpiexec will now abort.  No processes were launched.
--------------------------------------------------------------------------

Questions/Ideas

This issue is already identified on the openmpi project open-mpi/ompi#5613.

To my understanding, the issue exists on systems (Arch, Ubuntu) where /bin/ is a symlink to /usr/bin. A kind of nasty loop occurs.

A fix on khiops-python was already committed once 75d0bf7 but unfortunately seems to have been reverted.

The symlink was followed and the real binary was reached.

/bin/mpiexec -> /etc/alternatives/mpiexec -> /usr/bin/mpiexec.openmpi

I think we should put back this fix.

The text was updated successfully, but these errors were encountered:

Member

folmos-at-orange commented Jul 19, 2024

Why/how the commit 75d0bf7 was lost?

folmos-at-orange added Priority/0-High Type/Bug Status/ReadyForDev labels

folmos-at-orange changed the title ~~openmpi path issue when running khiops 10.2.2-1 on Arch+debian-like OS using khiops-python~~ openmpi path issue when running khiops 10.2.2-1 on Arch+debian-like OS

folmos-at-orange changed the title ~~openmpi path issue when running khiops 10.2.2-1 on Arch+debian-like OS~~ OpenMPI path issue with khiops 10.2.2 on Arch+debian-like OS

Collaborator

popescu-v commented Jul 29, 2024 •

edited

Loading

Why/how the commit 75d0bf7 was lost?

It was lost on some rebasing / folding of the commits in the PR #187 IIRC (at that time I thought that this fix was no longer necessary, as it was needed in the context of the wrong inference of the Conda binary directory when running tests with non-Conda khiops inside Conda environments - as in our unit-tests workflow).

popescu-v changed the title ~~OpenMPI path issue with khiops 10.2.2 on Arch+debian-like OS~~ OpenMPI path issue with khiops 10.2.2 on Debian-like OS

Member

folmos-at-orange commented Jul 29, 2024

Ok, no prob. Just in case I restored the commit in this issue's branch.

Collaborator

popescu-v commented Jul 30, 2024

Ok, no prob. Just in case I restored the commit in this issue's branch.

As, in all likelihood, this is a bug, I would have made a flash release with this fix only, without waiting for this branch to be ready to merge.

popescu-v added a commit that referenced this issue


          Add '/bin' before '/usr/bin' in PATH

9b0d1fa

Thus, mpiexec can be /bin/mpiexec through symlinks

related_to #209

popescu-v added a commit that referenced this issue


          Compute real path to mpiexec

e9ac545

Otherwise, in some situations, we get to /bin/mpiexec (which is
a symlink to the real path) which makes OpenMPI fail; see:
open-mpi/ompi#5613

closes #209

popescu-v added a commit that referenced this issue


          Add '/bin' before '/usr/bin' in PATH

37b1cb5

Thus, mpiexec can be /bin/mpiexec through symlinks

related_to #209

popescu-v added a commit that referenced this issue


          Compute real path to mpiexec

62177c1

Otherwise, in some situations, we get to /bin/mpiexec (which is
a symlink to the real path) which makes OpenMPI fail; see:
open-mpi/ompi#5613

closes #209

popescu-v added a commit that referenced this issue


          Add '/bin' before '/usr/bin' in PATH

8c3b977

Thus, mpiexec can be /bin/mpiexec through symlinks

related_to #209

popescu-v added a commit that referenced this issue


          Compute real path to mpiexec

4e64b82

Otherwise, in some situations, we get to /bin/mpiexec (which is
a symlink to the real path) which makes OpenMPI fail; see:
open-mpi/ompi#5613

closes #209

popescu-v linked a pull request

that will close this issue

209 openmpi path issue with khiops 1022 on debian like os #218

Merged

popescu-v mentioned this issue

209 openmpi path issue with khiops 1022 on debian like os #218

Merged

popescu-v added a commit that referenced this issue


          Add '/bin' before '/usr/bin' in PATH

1be188a

Thus, mpiexec can be /bin/mpiexec through symlinks

related_to #209

popescu-v added a commit that referenced this issue


          Compute real path to mpiexec

49c3e6b

Otherwise, in some situations, we get to /bin/mpiexec (which is
a symlink to the real path) which makes OpenMPI fail; see:
open-mpi/ompi#5613

closes #209

popescu-v added a commit that referenced this issue


          Add '/bin' before '/usr/bin' in PATH

bcfaadc

Thus, mpiexec can be /bin/mpiexec through symlinks

related_to #209

popescu-v added a commit that referenced this issue


          Compute real path to mpiexec

7c14b07

Otherwise, in some situations, we get to /bin/mpiexec (which is
a symlink to the real path) which makes OpenMPI fail; see:
open-mpi/ompi#5613

closes #209

popescu-v added a commit that referenced this issue


          Add '/bin' before '/usr/bin' in PATH in the CI

7074dd5

Thus, mpiexec can be /bin/mpiexec through symlinks

related_to #209

popescu-v closed this as completed in #218

popescu-v closed this as completed in

33586e0

folmos-at-orange added this to the 10.2.2.3 milestone

folmos-at-orange added Status/Done and removed Status/ReadyForDev labels

folmos-at-orange assigned popescu-v

folmos-at-orange removed the Priority/0-High label

Collaborator

popescu-v commented Oct 9, 2024

Actually, the issue occurs if /bin is before /usr/bin in PATH, but this does not occur in vanilla versions of any Linux that Khiops currently supports, viz Ubuntu 20.04, 22.04, 24.04 ; Rocky 8, 9 ; Debian 10, 11, 12.

Arch (mentioned in the issue) is not currently supported by Khiops.

popescu-v added a commit that referenced this issue


          Keep vanilla PATH as on the supported Linux OSes

468f417

This path change was meant to test issue
#209, which is moot in
our case, because:

- all currently supported Linux distributions (Ubuntu 20.04, 22.04, 24.04;
  Rocky 8, 9; Debian 10, 11, 12) have `/usr/bin` before `/bin` in `PATH`
- the Arch Linux distribution that is mentioned in the above-cited issue
  is not currently supported.

popescu-v added a commit that referenced this issue


          Keep vanilla PATH as on the supported Linux OSes

This path change was meant to test issue
#209, which is moot in
our case, because:

- all currently supported Linux distributions (Ubuntu 20.04, 22.04, 24.04;
  Rocky 8, 9; Debian 10, 11, 12) have `/usr/bin` before `/bin` in `PATH`
- the Arch Linux distribution that is mentioned in the above-cited issue
  is not currently supported.

popescu-v added a commit that referenced this issue


          Keep vanilla PATH as on the supported Linux OSes

f2bf036

This path change was meant to test issue
#209, which is moot in
our case, because:

- all currently supported Linux distributions (Ubuntu 20.04, 22.04, 24.04;
  Rocky 8, 9; Debian 10, 11, 12) have `/usr/bin` before `/bin` in `PATH`
- the Arch Linux distribution that is mentioned in the above-cited issue
  is not currently supported.

popescu-v added a commit that referenced this issue


          Keep vanilla PATH as on the supported Linux OSes

05bf4e2

This path change was meant to test issue
#209, which is moot in
our case, because:

- all currently supported Linux distributions (Ubuntu 20.04, 22.04, 24.04;
  Rocky 8, 9; Debian 10, 11, 12) have `/usr/bin` before `/bin` in `PATH`
- the Arch Linux distribution that is mentioned in the above-cited issue
  is not currently supported.

popescu-v added a commit that referenced this issue


          Keep vanilla PATH as on the supported Linux OSes

9fcca45

This path change was meant to test issue
#209, which is moot in
our case, because:

- all currently supported Linux distributions (Ubuntu 20.04, 22.04, 24.04;
  Rocky 8, 9; Debian 10, 11, 12) have `/usr/bin` before `/bin` in `PATH`
- the Arch Linux distribution that is mentioned in the above-cited issue
  is not currently supported.

popescu-v added a commit that referenced this issue


          Keep vanilla PATH as on the supported Linux OSes

9bdaa08

This path change was meant to test issue
#209, which is moot in
our case, because:

- all currently supported Linux distributions (Ubuntu 20.04, 22.04, 24.04;
  Rocky 8, 9; Debian 10, 11, 12) have `/usr/bin` before `/bin` in `PATH`
- the Arch Linux distribution that is mentioned in the above-cited issue
  is not currently supported.

popescu-v added a commit that referenced this issue


          Keep vanilla PATH as on the supported Linux OSes

3c8117f

This path change was meant to test issue
#209, which is moot in
our case, because:

- all currently supported Linux distributions (Ubuntu 20.04, 22.04, 24.04;
  Rocky 8, 9; Debian 10, 11, 12) have `/usr/bin` before `/bin` in `PATH`
- the Arch Linux distribution that is mentioned in the above-cited issue
  is not currently supported.

popescu-v added a commit that referenced this issue


          Keep vanilla PATH as on the supported Linux OSes

b3deea0

This path change was meant to test issue
#209, which is moot in
our case, because:

- all currently supported Linux distributions (Ubuntu 20.04, 22.04, 24.04;
  Rocky 8, 9; Debian 10, 11, 12) have `/usr/bin` before `/bin` in `PATH`
- the Arch Linux distribution that is mentioned in the above-cited issue
  is not currently supported.

popescu-v added a commit that referenced this issue


          Keep vanilla PATH as on the supported Linux OSes

a5be89c

This path change was meant to test issue
#209, which is moot in
our case, because:

- all currently supported Linux distributions (Ubuntu 20.04, 22.04, 24.04;
  Rocky 8, 9; Debian 10, 11, 12) have `/usr/bin` before `/bin` in `PATH`
- the Arch Linux distribution that is mentioned in the above-cited issue
  is not currently supported.

folmos-at-orange removed the Type/Bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment