Skip to content

decimal convertion fix && hurt note feature #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Spzabt-zz
Copy link

In Note.cs, the OnlyDecimalConverter class has been added for more accurate processing of "sectionNotes" data. This converter helps filter out incompatible types (anything that isn't decimal or integer), like this (which I found in this mod):

[
    1463.41463414634
    ,2
    ,365.853658536585
    ,[

    ]
]

turns into this:

[
    1463.41463414634,
    2,
    365.853658536585
]

Also added option to skip "Hurt Notes", for example:

[
    24468.75,
    7,
    0,
    "Hurt Note"
]

turns into this:

[
    24468.75,
    2147483647,
    0
]

where the value 2147483647 becomes unrecognized by FNFBot.

In FNFSection within FNFSong.cs, made some adjustments to ensure that the Notes list is correctly populated by adding missing elements or removing extra elements to maintain a valid structure. Because in some mods there could be more than 3 sections in the "sectionNotes" or less (in very rare cases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant