Make it possible to specify float type as well #228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have an application dealing with decimal money amounts sent via JSON, I want to parse these as a FixedPointDecimal ( https://github.com/JuliaMath/FixedPointDecimals.jl) to make sure floating point doesn't mess up my amounts. This code is sufficient to convience JSON.jl to parse numbers as FixedPointDecimals.
|
Looks good! Can you add some tests? |
|
It would be good to have this tested with https://github.com/stevengj/DecFP.jl as well. |
|
@Keno are you still interested in this pull request? |
|
abstractly yes, but I'm unlikely to have the time to get back to it in the near future, so feel free to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an application dealing with decimal money amounts sent via JSON,
I want to parse these as a FixedPointDecimal (
https://github.com/JuliaMath/FixedPointDecimals.jl) to make sure floating
point doesn't mess up my amounts. This code is sufficient to convience
JSON.jl to parse numbers as FixedPointDecimals.