This repository was archived by the owner on Jan 14, 2019. It is now read-only.
feat: update TSFunctionType and TSConstructorType nodes #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not shure if we should change name of paramerters here to as we did for other function like nodes, |
|
Yeah, let's do that for now please |
BREAKING CHANGE: This changes the AST
|
should we also do this for other function like types? like: type Constructor<T> = new (...args: any[]) => T; |
|
ohh, right this issue is going to be present in |
BREAKING CHANGE: This changes the AST
|
@JamesHenry can you review it once more? i fixed also issue with |
armano2
changed the title
armano2
changed the title
|
🎉 This PR is included in version 13.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes range of TypeAnnotation in function type:
before:
> voidafter:
=> void