-
Notifications
You must be signed in to change notification settings - Fork 42
Modernize setuptools bootstrap script #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution. I am all in favour of removing
I don't think we should use it. Instead, we should just modernize |
OK, I updated the PR accordingly. |
Now the PR also adds pyproject.toml file with now information about it in the commit. In fact I have just learned about PEP 518 right now. I don't think we need it. As added, it contains the defaults tools should use any way. And I don't think 'wheel' is actually needed now to build PyXMPP2. I would also prefer the change as a single commit – could you squash the two commits into one? The only thing left will probably be removal of ez_setup and distribute import from setup.py. |
Pip should do this automatically as per PEP 508.
Done! After merging this, would you please roll a new release so that it is |
Merged, thanks. I'll try to make a release this weekend. I have mixed feelings, as PyXMPP is a bit abandoned now, but if it works and there are people interested, I can push this as a new 'release'. |
We still use pyxmpp in the LIGO and Virgo gravitational-wave observatories, although we have been looking at more modern alternatives. It would be very nice to get a new release of pyxmpp2 that works with pip so that we have a Python 3 compatible xmpp library if we end up sticking with xmpp for our next observing run. |
Wow! Then I will make the release soon. :-) |
Done. |
Jajcus/pyxmpp2#91 was fixed in pyxmpp2-2.0.1.
Thank you! As you can see I'm already using this. |
The old
distribute_setup.py
bootstrap script does not even work any more, because an exception is raised when it makes a request from PyPI using a non-https URL (urllib.error.HTTPError: HTTP Error 403: SSL is required
). This made it impossible to install pyxmpp2 using pip.Switch to using the latest bootstrap script
ez_setup.py
from the modern Setuptools project.