Skip to content

Modernize setuptools bootstrap script #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2017
Merged

Conversation

lpsinger
Copy link
Contributor

The old distribute_setup.py bootstrap script does not even work any more, because an exception is raised when it makes a request from PyPI using a non-https URL (urllib.error.HTTPError: HTTP Error 403: SSL is required). This made it impossible to install pyxmpp2 using pip.

Switch to using the latest bootstrap script ez_setup.py from the modern Setuptools project.

@Jajcus
Copy link
Owner

Jajcus commented Nov 24, 2017

Thank you for your contribution.

I am all in favour of removing distribute_setup.py, but the included ez_setup.py script states in its description:

This method is DEPRECATED. Check pypa/setuptools#581 for more details.

I don't think we should use it. Instead, we should just modernize setup.py, removing all traces of distribute.

@lpsinger
Copy link
Contributor Author

OK, I updated the PR accordingly.

@Jajcus
Copy link
Owner

Jajcus commented Nov 24, 2017

Now the PR also adds pyproject.toml file with now information about it in the commit. In fact I have just learned about PEP 518 right now. I don't think we need it. As added, it contains the defaults tools should use any way. And I don't think 'wheel' is actually needed now to build PyXMPP2.

I would also prefer the change as a single commit – could you squash the two commits into one? The only thing left will probably be removal of ez_setup and distribute import from setup.py.

Pip should do this automatically as per PEP 508.
@lpsinger
Copy link
Contributor Author

Now the PR also adds pyproject.toml file with now information about it in the commit. In fact I have just learned about PEP 518 right now. I don't think we need it. As added, it contains the defaults tools should use any way. And I don't think 'wheel' is actually needed now to build PyXMPP2.

I would also prefer the change as a single commit – could you squash the two commits into one? The only thing left will probably be removal of ez_setup and distribute import from setup.py.

Done! After merging this, would you please roll a new release so that it is pip install-able?

@Jajcus Jajcus merged commit 8cf66a7 into Jajcus:master Nov 24, 2017
@Jajcus
Copy link
Owner

Jajcus commented Nov 24, 2017

Merged, thanks.

I'll try to make a release this weekend. I have mixed feelings, as PyXMPP is a bit abandoned now, but if it works and there are people interested, I can push this as a new 'release'.

@lpsinger lpsinger deleted the setuptools branch November 24, 2017 17:05
@lpsinger lpsinger restored the setuptools branch November 24, 2017 17:06
@lpsinger
Copy link
Contributor Author

I'll try to make a release this weekend. I have mixed feelings, as PyXMPP is a bit abandoned now, but if it works and there are people interested, I can push this as a new 'release'.

We still use pyxmpp in the LIGO and Virgo gravitational-wave observatories, although we have been looking at more modern alternatives. It would be very nice to get a new release of pyxmpp2 that works with pip so that we have a Python 3 compatible xmpp library if we end up sticking with xmpp for our next observing run.

@Jajcus
Copy link
Owner

Jajcus commented Nov 27, 2017

We still use pyxmpp in the LIGO and Virgo gravitational-wave observatories,

Wow! Then I will make the release soon. :-)

@Jajcus
Copy link
Owner

Jajcus commented Nov 27, 2017

Done.

@lpsinger lpsinger deleted the setuptools branch November 27, 2017 20:44
lpsinger added a commit to lpsinger/gwcelery that referenced this pull request Nov 27, 2017
@lpsinger
Copy link
Contributor Author

Thank you! As you can see I'm already using this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants