-
Notifications
You must be signed in to change notification settings - Fork 28
Draft local state query serialization tests #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: js/cddls
Are you sure you want to change the base?
Conversation
Concatenating is fine with simple examples, however I really doubt one can define the block CDDL keeping their sanity with only concat. I do think
I'm preparing a validator here: input-output-hk/cuddle#68. As opposed to
No objections from my side. One thing that I would like to note here is that GetSystemStart is presumably one of the easiest specs. I want to warn not to commit to something that works for this simple case and then becomes a horrible nightmare to adapt it to the multi thousand lines CDDLs for blocks and others. Note this suggestion is both for these ouroboros-consensus stuff as well as the CDDLs in the blueprint itself. |
4ede539
to
0e37093
Compare
17cc4cb
to
9701802
Compare
dd7f609
to
803c0cf
Compare
Experimented with how we would want to test against CDDLs in https://github.com/cardano-scaling/cardano-blueprint/ from this repository.
This is incomplete, but I'd like to gather some feedback already on:
UTCTime
not fully roundtripping becausedayOfYear
is clamped to[1, 366]
- would we want that anyCBOR
that is valid against aCDDL
to roundtrip, i.e.CBOR -> result -> CBOR
?.cddl
files, while @jasagredo started using cddl module extensions. However that requirescddlc
and I was not feeling like packaging that for NixOS. Do we really want/need;# include
? If yes, is thecddlc
gem the way to go or should we extend https://github.com/input-output-hk/cuddle?CBOR
againstCDDL
can only be done with thecddl
gem, which is not open source (anymore?) and it's error output is just insane (thousands of repeated lines of errors). Do we want Add support for validating CBOR input-output-hk/cuddle#7 instead?cardano-blueprint
?