Skip to content

Fix occurrence of items in maps in byron.cddl #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Conversation

jasagredo
Copy link
Contributor

Description

These maps were wrong in the CDDL. I found this out validating chunk 00007.chunk as a cborseq.

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@jasagredo jasagredo requested a review from a team as a code owner May 21, 2025 15:05
@jasagredo jasagredo added the cddl Issues related to cddl specification label May 21, 2025
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lehins lehins merged commit cb3d4bb into master May 21, 2025
128 checks passed
@lehins lehins deleted the js/byron-cddl-fixes branch May 21, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cddl Issues related to cddl specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants