-
Notifications
You must be signed in to change notification settings - Fork 157
Expose Byron CDDLs in Test.Cardano.Chain.Binary.Cddl
#4965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm unsure if this deserves changelog entries and/or version bumps |
I think the changelog and version are not problem, but I'm a little unsure about all the consequences of moving the files. It will, at least, break the link on the README: https://github.com/intersectmbo/cardano-ledger/tree/master/eras/byron/cddl-spec/byron.cddl |
69c1404
to
becb15d
Compare
becb15d
to
d48965e
Compare
I updated all links I could find to the Byron cddls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Thank you! 🙂
Should I click merge or is it better if I let someone from @IntersectMBO/cardano-ledger-maintainers do it instead? |
As long as it is approved and CI is passing, there is no reason why it can't be merged 😉 |
Description
This PR replicates the logic in
Test.Cardano.Ledger.<ERA>.Binary.Cddl
for exposing the cddl files.Checklist
Tests added or updated when needed.CHANGELOG.md
files updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabal
andCHANGELOG.md
files when necessary, according to theversioning process.
.cabal
files updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh
).scripts/cabal-format.sh
).hie.yaml
updated (usescripts/gen-hie.sh
).