Skip to content

Expose Byron CDDLs in Test.Cardano.Chain.Binary.Cddl #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Apr 1, 2025

Description

This PR replicates the logic in Test.Cardano.Ledger.<ERA>.Binary.Cddl for exposing the cddl files.

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@jasagredo jasagredo requested a review from a team as a code owner April 1, 2025 13:01
@jasagredo
Copy link
Contributor Author

I'm unsure if this deserves changelog entries and/or version bumps

@teodanciu
Copy link
Contributor

I think the changelog and version are not problem, but I'm a little unsure about all the consequences of moving the files. It will, at least, break the link on the README: https://github.com/intersectmbo/cardano-ledger/tree/master/eras/byron/cddl-spec/byron.cddl

@jasagredo jasagredo force-pushed the js/expose-byron-cddls branch 2 times, most recently from 69c1404 to becb15d Compare April 1, 2025 14:01
@jasagredo jasagredo force-pushed the js/expose-byron-cddls branch from becb15d to d48965e Compare April 1, 2025 14:03
@jasagredo
Copy link
Contributor Author

I updated all links I could find to the Byron cddls.

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you! 🙂

@jasagredo
Copy link
Contributor Author

jasagredo commented Apr 1, 2025

Should I click merge or is it better if I let someone from @IntersectMBO/cardano-ledger-maintainers do it instead?

@lehins
Copy link
Collaborator

lehins commented Apr 1, 2025

As long as it is approved and CI is passing, there is no reason why it can't be merged 😉

@jasagredo jasagredo merged commit 0c8706f into master Apr 1, 2025
152 of 155 checks passed
@jasagredo jasagredo deleted the js/expose-byron-cddls branch April 1, 2025 16:47
@lehins lehins added the cddl Issues related to cddl specification label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cddl Issues related to cddl specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants