Skip to content

update blockedfp8 scale name #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

update blockedfp8 scale name #3532

merged 3 commits into from
May 12, 2025

Conversation

CUHKSZzxy
Copy link
Collaborator

@CUHKSZzxy CUHKSZzxy commented May 9, 2025 •
edited
Loading

Rename blocked fp8 scale => weight_scale_inv in nn.linear and nn.moe, then we don't need to deal with scale suffix for each blocked-fp8 model.

@lvhan028 lvhan028 requested review from grimoire and RunningLeon May 9, 2025 09:49
RunningLeon
RunningLeon approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grimoire
grimoire approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 2831c3a into InternLM:main May 12, 2025
5 of 6 checks passed
@CUHKSZzxy CUHKSZzxy deleted the rename-blockedfp8-scale branch May 13, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grimoire grimoire grimoire approved these changes

@RunningLeon RunningLeon RunningLeon approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CUHKSZzxy @grimoire @RunningLeon @lvhan028