Skip to content

Add third party tests for dpnp.linalg.cond #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 19, 2025
Merged

Add third party tests for dpnp.linalg.cond #2482

merged 5 commits into from
Jun 19, 2025
+146 −3

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 17, 2025 •
edited
Loading

This PR adds third party tests for dpnp.linalg.cond function.
Also it adds more clarity in documentation on possible values of p keyword.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Jun 17, 2025
@antonwolfy antonwolfy changed the title Add third party tests for dpnp.linalgcond` Add third party tests for dpnp.linalg.cond Jun 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_22 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jun 17, 2025 •
edited
Loading

Coverage Status

coverage: 71.863%. remained the same
when pulling 77de059 on third-party-tests-for-linalg-cond
into aec9934 on master.

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jun 18, 2025
@antonwolfy antonwolfy marked this pull request as ready for review June 18, 2025 11:32
vtavana
vtavana approved these changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 03e5ba0 into master Jun 19, 2025
66 of 68 checks passed
@antonwolfy antonwolfy deleted the third-party-tests-for-linalg-cond branch June 19, 2025 20:43
github-actions bot added a commit that referenced this pull request Jun 19, 2025
@github-actions
Add third party tests for dpnp.linalg.cond (#2482)
3c7230b 
This PR adds third party tests for `dpnp.linalg.cond` function.
Also it adds more clarity in documentation on possible values of `p`
keyword. 03e5ba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana