Skip to content

Fixed crash reported in #345 #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

oleksandr-pavlyk
Copy link
Contributor

Closes #345

(idp) [20:48:49 ansatnuc04 dpctl]$ SYCL_DEVICE_FILTER=cuda python -c "import dpctl; dpctl.get_current_queue()"
No device of requested type available. Please check https://software.intel.com/content/www/us/en/develop/articles/intel-oneapi-dpcpp-system-requirements.html -1 (CL_DEVICE_NOT_FOUND)
No currently active queues.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "dpctl/_sycl_queue_manager.pyx", line 174, in dpctl._sycl_queue_manager.get_current_queue
    cpdef SyclQueue get_current_queue():
  File "dpctl/_sycl_queue_manager.pyx", line 188, in dpctl._sycl_queue_manager.get_current_queue
    return _mgr.get_current_queue()
  File "dpctl/_sycl_queue_manager.pyx", line 91, in dpctl._sycl_queue_manager._SyclQueueManager.get_current_queue
    cpdef SyclQueue get_current_queue(self):
  File "dpctl/_sycl_queue_manager.pyx", line 105, in dpctl._sycl_queue_manager._SyclQueueManager.get_current_queue
    return SyclQueue._create(DPCTLQueueMgr_GetCurrentQueue())
  File "dpctl/_sycl_queue.pyx", line 372, in dpctl._sycl_queue.SyclQueue._create
    raise SyclQueueCreationError("Queue creation failed.")
dpctl._sycl_queue.SyclQueueCreationError: Queue creation failed.

```
(idp) [20:48:49 ansatnuc04 dpctl]$ SYCL_DEVICE_FILTER=cuda python -c "import dpctl; dpctl.get_current_queue()"
No device of requested type available. Please check https://software.intel.com/content/www/us/en/develop/articles/intel-oneapi-dpcpp-system-requirements.html -1 (CL_DEVICE_NOT_FOUND)
No currently active queues.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "dpctl/_sycl_queue_manager.pyx", line 174, in dpctl._sycl_queue_manager.get_current_queue
    cpdef SyclQueue get_current_queue():
  File "dpctl/_sycl_queue_manager.pyx", line 188, in dpctl._sycl_queue_manager.get_current_queue
    return _mgr.get_current_queue()
  File "dpctl/_sycl_queue_manager.pyx", line 91, in dpctl._sycl_queue_manager._SyclQueueManager.get_current_queue
    cpdef SyclQueue get_current_queue(self):
  File "dpctl/_sycl_queue_manager.pyx", line 105, in dpctl._sycl_queue_manager._SyclQueueManager.get_current_queue
    return SyclQueue._create(DPCTLQueueMgr_GetCurrentQueue())
  File "dpctl/_sycl_queue.pyx", line 372, in dpctl._sycl_queue.SyclQueue._create
    raise SyclQueueCreationError("Queue creation failed.")
dpctl._sycl_queue.SyclQueueCreationError: Queue creation failed.
```
@PokhodenkoSA
Copy link
Contributor

C API implementation should catch (...) too because any exception will be unexpected for C API users.

@oleksandr-pavlyk
Copy link
Contributor Author

Closing without merging, as #349 is more comprehensive and includes the change proposed here.

@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-crash/issue-345 branch April 2, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Fatal Python error: Aborted" in test_dparray_T
2 participants