-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
gpgme 1.17.0 #94966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpgme 1.17.0 #94966
Conversation
It's no longer needed.
Something is going wrong with our Possibly related failure message:
After which, the install puts files inside: |
def install | ||
ENV["PYTHON"] = Formula["[email protected]"].opt_bin/"python3" | ||
ENV["SETUPTOOLS_USE_DISTUTILS"] = "stdlib" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do-not-merge for now since this may be better to handle inside [email protected]
/[email protected]
formulae.
Upstream setuptools >= 60
change: pypa/setuptools#2896
It looks like there was some discussion in relation to Homebrew, so there may already be a fix/workaround in place.
Need someone familiar with current status to provide guidance on proper solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the workaround used in other formulae, so I'm fine with this. We should add a comment documenting this, though.
I also wonder if these patches should be handling this:
homebrew-core/Formula/[email protected]
Lines 62 to 75 in debd7ef
# Modify default sysconfig to match the brew install layout. | |
# Remove when a non-patching mechanism is added (https://bugs.python.org/issue43976). | |
# We (ab)use osx_framework_library to exploit pip behaviour to allow --prefix to still work. | |
patch do | |
url "https://raw.githubusercontent.com/Homebrew/formula-patches/a1618a5005d0b01d63b720321806820a03432f1a/python/3.10-sysconfig.diff" | |
sha256 "51bc741a7f201bf7382067f5561a10968476c98d952e54a4f1931f17f1397ef8" | |
end | |
# Make bundled distutils look at preferred sysconfig scheme. | |
# Remove with Python 3.12. | |
patch do | |
url "https://raw.githubusercontent.com/Homebrew/formula-patches/a1618a5005d0b01d63b720321806820a03432f1a/python/3.10-distutils-scheme.diff" | |
sha256 "d1a29b3c9ecf8aecd65e1e54efc42fb1422b2f5d05cba0c747178f4ef8a69683" | |
end |
CC @Bo98
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a comment like git-cola
with possible fix if distutils
is no longer needed with https://dev.gnupg.org/D545
2355227
to
561aae0
Compare
🤖 A scheduled task has triggered a merge. |
Created with
brew bump-formula-pr
.