Skip to content

create command to allow to create functions #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GuillaumeGomez opened this issue Oct 1, 2022 · 1 comment · Fixed by #372
Closed

create command to allow to create functions #363

GuillaumeGomez opened this issue Oct 1, 2022 · 1 comment · Fixed by #372

Comments

@GuillaumeGomez
Copy link
Owner

GuillaumeGomez commented Oct 1, 2022 •
edited
Loading

It's quite current to repeat the same instructions to check different things. It could look like this:

define-function: (
    "function_name",
    (arg_name1, arg_name2, arg_name3),
    [
        ("move-cursor-to", |arg_name1|),
        ("assert-css", (|arg_name1|, {|arg_name2|: |arg_name3|}),
    ],
)

Then it would be called like this:

call-function: ("function_name", ("CSS selector", "border-color", "rgb(255, 255, 255)"))
@GuillaumeGomez
Copy link
Owner Author

#364 would be a very nice add alongside this feature too.

@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 1, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 4, 2022
@matthiaskrgr
Rollup merge of rust-lang#102547 - GuillaumeGomez:migrate-css-theme-s…
f333436 
…earch-result, r=notriddle,jsha

Migrate CSS theme for search results

Part of rust-lang#98460.

Just like rust-lang#102237, I unified theme to how the `ayu` handles this one: only one color for the background when search results are focused or hovered.

You can test it [here](https://rustdoc.crud.net/imperio/migrate-css-theme-search-result/lib2/index.html?search=coo).

cc `@jsha`
r? `@notriddle`

PS: The repetition in GUI tests is getting out of hand so I opened GuillaumeGomez/browser-UI-test#363 to think about adding possibility to declare functions so we can greatly improve this.
@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add define-function and call-function commands GuillaumeGomez/browser-UI-test
1 participant
@GuillaumeGomez