Skip to content

feat: added fleet scope logging #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024

Conversation

yliaog
Copy link
Collaborator

@yliaog yliaog commented Feb 23, 2024

No description provided.

@yliaog yliaog requested review from gtsorbo and a team as code owners February 23, 2024 23:28
@apeabody apeabody changed the title added fleet scope logging feat: added fleet scope logging Feb 23, 2024
@apeabody apeabody marked this pull request as draft April 4, 2024 17:39
@apeabody
Copy link
Collaborator

apeabody commented May 6, 2024

Hi @yliaog - Once the project_id are updated, this PR should now work.

@yliaog yliaog marked this pull request as ready for review May 6, 2024 21:10
@apeabody
Copy link
Collaborator

apeabody commented May 7, 2024

Yay!

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yliaog - LGTM!

@gtsorbo?

@gtsorbo gtsorbo merged commit d2ec68c into GoogleCloudPlatform:main May 7, 2024
4 checks passed
@release-please release-please bot mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants