Implementing pack-gen #42
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as far I understand, the current repository doesn't implement pack generation. (The third issue #3 is still open). So, before pack-send, we obviously need to generate packs first.
So, to begin implemention, I start by understanding the original C code, starting with pack-objects.c? I have read the Git Internals part of the ProGit book, but it felt surface level in this context.
So, as apparent from the README, I should likely first look at these three tasks, starting with the first:
Ideally, this functionality would be implemented in
git-odb/src/pack/data/encode.rs
.Is this overall understanding correct?