Config filename case insensitive #4452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturcic
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the configuration filename lookup on case sensitive file systems by ensuring that file name comparisons are done in a case-insensitive manner.
- Adds a new test to verify that configuration file lookup succeeds when file names differ only in case.
- Refactors the SupportedConfigFileNames field and improves the candidate selection logic in GetConfigurationFile.
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/GitVersion.Configuration.Tests/Configuration/ConfigurationFileLocatorTests.cs | Added a new test verifying that file lookup works regardless of filename casing. |
| src/GitVersion.Configuration/ConfigurationFileLocator.cs | Rewritten candidate lookup and logging details; changed SupportedConfigFileNames field from public list to private readonly array. |
Comments suppressed due to low confidence (1)
src/GitVersion.Configuration/ConfigurationFileLocator.cs:66
- [nitpick] The debug message logs only the directory instead of the candidate file name being evaluated, which may reduce the clarity of log output during troubleshooting. Consider logging the candidate file name to improve debugging visibility.
this.log.Debug($"Configuration file not found at '{directory}'");
arturcic
force-pushed
the
fix/config-filename-case-insensitive
branch
from
035827e to
0388b70
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that configuration filename lookup is case insensitive, preventing errors on case sensitive file systems.
- Introduces a new test to verify that configuration files are detected regardless of casing.
- Refactors candidate file lookup logic and logging in the configuration file locator.
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/GitVersion.Configuration.Tests/Configuration/ConfigurationFileLocatorTests.cs | Added a test case to ensure that configuration files differing only in casing are correctly detected. |
| src/GitVersion.Configuration/ConfigurationFileLocator.cs | Updated candidate lookup logic and logging to perform a case insensitive search for configuration files. |
|
Thank you @arturcic for your contribution! |
|
🎉 This issue has been resolved in version 6.2.0 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the they we look for a configuration filename on case sensitive file systems/oses