Skip to content

[11.9] Remove Trailing slash on project path #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

ajuchacko
Copy link
Contributor

Fix: #739

✅ Added Testcase
✅ All tests are passing on local

@ajuchacko ajuchacko changed the title Trailing slash on uri Remove Trailing slash on project path Apr 4, 2023
@ajuchacko ajuchacko marked this pull request as ready for review April 4, 2023 15:56
@danepowell
Copy link

Tested and confirmed this fixes #739 (and by extension, https://github.com/acquia/cli/issues/1377). Thanks!

@ajuchacko ajuchacko changed the title Remove Trailing slash on project path [11.10] Remove Trailing slash on project path Apr 8, 2023
@ajuchacko ajuchacko changed the title [11.10] Remove Trailing slash on project path [11.9] Remove Trailing slash on project path Apr 8, 2023
@GrahamCampbell
Copy link
Member

Thanks for starting work on this. I feel the root cause is that the project method is not meant to be called with an empty string. I've fixed this, accordingly.

@ajuchacko
Copy link
Contributor Author

Thanks for starting work on this. I feel the root cause is that the project method is not meant to be called with an empty string. I've fixed this, accordingly.

You're right, It makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cannot upload project avatar: 'avatar is invalid'
3 participants