Skip to content

GitHub action to release to nuget #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 23, 2021
Merged

Conversation

matt-lethargic
Copy link
Member

With this change I've added in a deploy job to the ci build action that will trigger when a GitHub Release is created with the name format v1.2.3 and subsequently push the package to Nuget

I've also created a new key.snk that the project uses when signing itself at build time.

@codecov-commenter
Copy link

Codecov Report

Merging #4 (1789750) into main (d0bd715) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files          31       31           
  Lines         753      753           
  Branches      192      192           
=======================================
  Hits          444      444           
  Misses        222      222           
  Partials       87       87           
Flag Coverage Δ
unittests 58.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0bd715...1789750. Read the comment docs.

@MartinCarpentier
Copy link
Contributor

MartinCarpentier commented Dec 21, 2021

Looks really nice, and great that it works with the github releases.

Could it make sense to split the build/test responsibility away from the deployment responsibility, and create 2 workflow files?

Something like

  • ci-build.yml
  • deploy.yml

Furthermore, does it also allow creating packages with formats like below?
v1.2.3-preview1

Since it would be great to be able to do preview releases.

@matt-lethargic matt-lethargic merged commit eba1551 into main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants