Skip to content

Test the benchmark run on pull request #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

MartinCarpentier
Copy link
Contributor

Set the benchmark to only run on pull requests, and removed the directory build props file, since it causes the benchmarking to fail.

Furthermore, signing the builds can be done directly from the CLI.

…ing to fail, and also the solution can be signed in other ways
@codecov-commenter
Copy link

Codecov Report

Merging #3 (8a6064c) into main (170bb3f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files          31       31           
  Lines         753      753           
  Branches      192      192           
=======================================
  Hits          444      444           
  Misses        222      222           
  Partials       87       87           
Flag Coverage Δ
unittests 58.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170bb3f...8a6064c. Read the comment docs.

Copy link
Member

@matt-lethargic matt-lethargic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@matt-lethargic matt-lethargic merged commit d0bd715 into main Dec 20, 2021
@MartinCarpentier MartinCarpentier deleted the feature/add-benchmarking branch December 20, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants