Feature/change project naming #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he SLN file to point to the new route after folder renaming
Updated the code to support system.text.json, and also updated the tests to run using system.text.json. Issues that needs fixing: Could not make the jsonconstructor work properly, so i updated the properties to be INIT. This does not solve that the classes can be instantiated invalidly, so more work might have to go into solving the jsonconstructors.
MartinCarpentier
force-pushed
the
feature/change-project-naming
branch
from
c0050f4 to
1b18a6a
Compare
MartinCarpentier
force-pushed
the
feature/change-project-naming
branch
from
1b18a6a to
4abf3ac
Compare
|
The code can build, tests work but some things needs to be adressed as explained below. Changes
Issues to look into
|
There was a problem hiding this comment.
An amazing PR, didn't think you were going to do it all in one go like that. Thank you. Have a look at my comments and once you've replied/resolved I'll get this in 👍
I sat down to have a look at this last night and I came to the same problem as you did with the constructors. This is something that will have to be lived with for now and addressed as and when.
src/GeoJSON.Text/Converters/JsonStringEnumEnumMemberConverter.cs
Outdated
Show resolved
Hide resolved
src/GeoJSON.Text/Converters/JsonStringEnumEnumMemberConverter.cs
Outdated
Show resolved
Hide resolved
matt-lethargic
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.