Skip to content

Update AGP and Android target/compile SDK versions #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

zacharee
Copy link
Contributor

Description

Just a small PR to bring some of the foundational Android stuff up-to-date. This fixes project sync in IntelliJ-based IDEs and unblocks some future changes.

Steps to verify

The project should still build successfully.

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 3608a2e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-app-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 1:37pm

@zibs zibs added the issue-accepted This issue has been confirmed and accepted by the maintainers label May 23, 2025
@zibs zibs self-assigned this May 23, 2025
@zibs zibs self-requested a review May 23, 2025 20:03
@zibs zibs requested a review from Copilot May 23, 2025 20:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Android Gradle Plugin and SDK levels to the latest supported versions to restore IDE sync and prepare the project for future changes.

  • Bump AGP classpath to 8.5.2
  • Update compileSdkVersion and targetSdkVersion to 34
  • Add a changeset entry to document the patch

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react-native-app-auth/android/build.gradle Upgrade AGP plugin and Android SDK versions
.changeset/angry-teachers-drop.md Add changelog for the AGP/SDK version update
Comments suppressed due to low confidence (1)

packages/react-native-app-auth/android/build.gradle:15

  • After bumping AGP to 8.5.2, ensure the Gradle wrapper distribution in gradle/wrapper/gradle-wrapper.properties is upgraded to a compatible Gradle version (e.g., Gradle 8.0+).
classpath 'com.android.tools.build:gradle:8.5.2'

@zibs zibs merged commit b75d340 into FormidableLabs:main May 23, 2025
2 checks passed
@zibs
Copy link
Contributor

zibs commented May 23, 2025

Thanks @zacharee! Sorry it took so long!

@github-actions github-actions bot mentioned this pull request May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-accepted This issue has been confirmed and accepted by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants