Skip to content

extend results on ceil 'for free' #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

extend results on ceil 'for free' #781

wants to merge 1 commit into from

Conversation

fdupress
Copy link
Member

This opaquely defines ceil from floor so all results on ceil apply to floor and don't need copied. We still start copying them.

This is minimally done for the purpose of a specific proof for now; feel free to ask me to make it draft for now.

This opaquely defines ceil from floor so all results on ceil apply to floor and don't need copied.
We still start copying them.
@fdupress fdupress requested a review from strub May 22, 2025 12:50
@fdupress fdupress self-assigned this May 22, 2025
@strub
Copy link
Member

strub commented May 24, 2025

Overall, this is ok. But I don't understand why this PR breaks external devs.

@fdupress
Copy link
Member Author

I don't either, I'll draft it until I understand what I need for the dev anyway.

I expect some brittle SMT solvers are made cranky by the fact that there is slightly more transparency here. (And if some solvers or their why3 driver defines floor in terms of ceil, for example, we could have some looping that evades detection during saturation.)

@strub
Copy link
Member

strub commented May 24, 2025

I on't remember wether opaque definitions are sent to SMT. I'll check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants