Fix HC collisions. #739
Merged
Fix HC collisions. #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
When hashing formulas, consider the type. This ensures consistency with formula equality checks and reduces collision rates, enhancing performance, especially with OCaml 5.
alleystoughton
approved these changes
Mar 6, 2025
|
Note that this doe snot fix the memory blow-up issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hashing formulas, consider the type. This ensures consistency with formula equality checks and reduces collision rates, enhancing performance, especially with OCaml 5.
See ocaml/ocaml#13849 for more information.