Skip to content

feat: upgrade go-dvls package to support more credential types #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sylfwood
Copy link
Contributor

@Sylfwood Sylfwood commented Jun 4, 2025

No description provided.

@Sylfwood Sylfwood requested a review from Copilot June 4, 2025 16:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the go-dvls package and updates various resources, data sources, and documentation to support additional credential types while ensuring consistency with the new API changes. Key changes include:

  • Refactoring field names (e.g. using "Id" instead of "ID") across certificate and credential resources.
  • Updating validations and dependency versions in go.mod.
  • Adjusting example configurations and documentation to reflect the new credential types.

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/provider/entry_credential_username_password_resource.go Implements credential resource using updated dvls package API.
internal/provider/entry_credential_username_password_data_source_test.go Test for the credential data source (appears to reference an undefined attribute).
internal/provider/entry_certificate_resource.go, entry_certificate_data_source.go, entry_certificate.go Updated to use new field naming conventions (Id instead of ID).
go.mod Dependency versions updated per go-dvls and Terraform Plugin Framework.
Examples and Docs Adjustments in resource and data source examples as well as documentation.
Comments suppressed due to low confidence (2)

internal/provider/entry_credential_username_password.go:16

  • [nitpick] The variable name 'entrycredentialusernamepassword' is quite long and may reduce readability. Consider using a shorter, more concise alias while keeping the meaning clear.
entrycredentialusernamepassword := dvls.Entry{

internal/provider/entry_credential_username_password_data_source_test.go:29

  • The test configuration is using an undefined attribute 'configurable_attribute'. Please update the test to use the attributes required by the data source schema (e.g. 'id' and 'vault_id').
  configurable_attribute = "EntryCredentialUsernamePassword"

@Sylfwood Sylfwood force-pushed the devops/dvls-provider branch from 186d4e5 to 03aba6b Compare June 4, 2025 17:04
@Sylfwood Sylfwood force-pushed the devops/dvls-provider branch from 03aba6b to 1243d5b Compare June 4, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant