Skip to content
This repository was archived by the owner on May 8, 2024. It is now read-only.

change default tsc options. use `--target es6 --module commonjs --exp… #15

Merged
merged 2 commits into from
Feb 9, 2016

Conversation

vvakame
Copy link
Member

@vvakame vvakame commented Feb 7, 2016

…erimentalDecorators`

@vvakame
Copy link
Member Author

vvakame commented Feb 7, 2016

The job exceeded the maxmimum time limit for jobs, and has been terminated. in travis ci...
I'll ignore it. We can't full test this tool in Travis CI now...

@DefinitelyTyped/contributors Can I merge this PR?
I want to use --target es6 default in DT repo.
Promise becomes standard API and used by a lot of scene.
now, definition-tester can use --target es6 with .tscparams, but it is not easy for understanding.
If you want to use --target es5, you should put .tscparams after this change released.

next step

  1. release new definition-tester.
  2. bump definition-tester version in DT repo & fix ci error.
  3. release to master/HEAD of DT repo.

@johnnyreilly
Copy link
Member

Fine with me

@horiuchi
Copy link
Member

horiuchi commented Feb 8, 2016

I think that's better. 👍

And so, this line is not needed: https://github.com/DefinitelyTyped/definition-tester/pull/15/files#diff-791ec60a6e04d0003ab8d665e2133f42R42

@vvakame
Copy link
Member Author

vvakame commented Feb 9, 2016

I'll merge this PR after dinner. (It is an hours ago)

vvakame added a commit that referenced this pull request Feb 9, 2016
change default tsc options. use `--target es6 --module commonjs --exp…
@vvakame vvakame merged commit 0170d04 into DefinitelyTyped:master Feb 9, 2016
@vvakame vvakame deleted the use-es6-default branch February 9, 2016 12:28
vvakame added a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Feb 9, 2016
@evmar
Copy link

evmar commented Feb 12, 2016

How do I use DefinitelyTyped definitions when targeting es5? It seems this change caused you to drop lots of reference to Promise<>.

@alexeagle
Copy link

If you target es5 then you need to include typings like https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/es6-promise/es6-promise.d.ts when you execute tsc.
Because of Duplicate identifiers, having these referenced from other libraries made it impossible to target --es6 due to microsoft/TypeScript#3215 (which is now assigned)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants