Skip to content

Make css-font-loading-module match TS 4.4's DOM #54042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

sandersn
Copy link
Contributor

TS 4.4 adds CSS Font Loading to the DOM. This PR makes it match those upcoming types.

Needed after microsoft/TypeScript#44684 is merged.

TS 4.4 adds CSS Font Loading to the DOM. This PR makes it match those
upcoming types.
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 24, 2021

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 54042,
  "author": "sandersn",
  "headCommitOid": "0659a546ecb6763fde6c73c20a9be0623bc2804b",
  "lastPushDate": "2021-06-24T18:01:16.000Z",
  "lastActivityDate": "2021-06-24T18:01:16.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "css-font-loading-module",
      "kind": "edit",
      "files": [
        {
          "path": "types/css-font-loading-module/css-font-loading-module-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/css-font-loading-module/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/css-font-loading-module/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.strictNullChecks`, `compilerOptions.lib.1`)"
        }
      ],
      "owners": [
        "slikts"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 867830733,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Check Config Changes a module config files labels Jun 24, 2021
@typescript-bot
Copy link
Contributor

🔔 @slikts — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 24, 2021
@typescript-bot
Copy link
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@sandersn sandersn changed the title Make css-front-loading-module match TS 4.4's DOM Make css-foont-loading-module match TS 4.4's DOM Jun 24, 2021
@sandersn sandersn changed the title Make css-foont-loading-module match TS 4.4's DOM Make css-font-loading-module match TS 4.4's DOM Jun 24, 2021
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jun 24, 2021
@sandersn sandersn merged commit 1efca30 into master Jun 25, 2021
@sandersn sandersn deleted the make-css-font-loading-match-dom branch June 25, 2021 17:42
@typescript-bot
Copy link
Contributor

I just published @types/[email protected] to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Check Config Changes a module config files Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants