Handle extra object literal properties (Part I) #5151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far. For reference, these are changes necessary to remove compiler errors after this change to the TypeScript compiler: microsoft/TypeScript#3823. Looks like it caught quite a few bugs already. |
|
🎉 for all the typos this is finding. It's fantastic. |
|
@DanielRosenwasser @danquirk @RyanCavanaugh thanks mates! 🐾 |
DanielRosenwasser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, accidentally sent out a PR - this isn't 100% complete yet. But if you'd like to review so that the next wave of changes isn't too massive, that works too.
This is part of sweep of work to address microsoft/TypeScript#4081
See Part II: #5233.
See Part III: #5346.
See Part IV: #5489
See Part V: #5645.