-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adaptive Sampling #29389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive Sampling #29389
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Brett! I made some minor suggestions, but there are no showstoppers to be seen 🙂
This option applies the configuration using Remote Configuration, so you **do not need** to redeploy the service for the change to take effect. You can observe the configuration changes from the [Live Search Explorer][100]. | ||
|
||
1. Click **Apply** to save the configuration. | ||
1. Resources that have been configured remotely display as `Configured Remote` in the **Configuration** column. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This second one isn't really a step. I think you could just convert this numbered list into a paragraph?
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
Co-authored-by: Janine Chan <[email protected]>
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do? What is the motivation?
Updates for adaptive sampling GA.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes