Skip to content

[No Ticket] Bump dependencies #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2021
Merged

[No Ticket] Bump dependencies #2125

merged 6 commits into from
May 19, 2021

Conversation

broadbot
Copy link
Contributor

Consolidate scala-steward PRs

@rtitle
Copy link
Collaborator

rtitle commented May 17, 2021

11:13:57 [warn] 	Note: Unresolved dependencies path:
11:13:57 [error] sbt.librarymanagement.ResolveException: Error downloading org.scalameta:semanticdb-scalac_2.13.6:4.4.10
11:13:57 [error]   Not found
11:13:57 [error]   Not found
11:13:57 [error]   not found: /root/.ivy2/localorg.scalameta/semanticdb-scalac_2.13.6/4.4.10/ivys/ivy.xml
11:13:57 [error]   not found: https://repo1.maven.org/maven2/org/scalameta/semanticdb-scalac_2.13.6/4.4.10/semanticdb-scalac_2.13.6-4.4.10.pom
11:13:57 [error]   not found: https://broadinstitute.jfrog.io/broadinstitute/libs-release/org/scalameta/semanticdb-scalac_2.13.6/4.4.10/semanticdb-scalac_2.13.6-4.4.10.pom
11:13:57 [error]   not found: https://broadinstitute.jfrog.io/broadinstitute/libs-snapshot/org/scalameta/semanticdb-scalac_2.13.6/4.4.10/semanticdb-scalac_2.13.6-4.4.10.pom
11:13:57 [error] 	a

@rtitle rtitle force-pushed the merged-scala-steward-prs branch from abe7ba8 to fb06fda Compare May 19, 2021 13:02
@rtitle
Copy link
Collaborator

rtitle commented May 19, 2021

Rebased.. hoping scalameta adds support for 2.13.6 soon

addCompilerPlugin(scalafixSemanticdb)
// Hard-coding the semanticdbVersion to make it work with Scala 2.13.6. It's possible this may be fixed
// in a future scalafix version. See: https://scalacenter.github.io/scalafix/docs/users/installation.html
semanticdbEnabled := true,
Copy link
Collaborator

@rtitle rtitle May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right way to install scalafix for sbt 1.3* and newer based on https://scalacenter.github.io/scalafix/docs/users/installation.html.

Although I had to hard-code the semanticdb version to work with Scala 2.13.6: https://mvnrepository.com/artifact/org.scalameta/semanticdb-scalac

@rtitle rtitle requested a review from Qi77Qi May 19, 2021 13:22
@rtitle
Copy link
Collaborator

rtitle commented May 19, 2021

Unit test error:

(update) sbt.librarymanagement.ResolveException: Error downloading org.scoverage:scalac-scoverage-plugin_2.13.6:1.4.6

Looks like there is no 2.13.6 version of scalac-scoverage-plugin :( https://mvnrepository.com/artifact/org.scoverage/scalac-scoverage-plugin

scoverage/scalac-scoverage-plugin#339

@rtitle rtitle added the blocked label May 19, 2021
@rtitle rtitle force-pushed the merged-scala-steward-prs branch from d79b7cc to 86438ab Compare May 19, 2021 20:43
@rtitle rtitle removed the blocked label May 19, 2021
@rtitle
Copy link
Collaborator

rtitle commented May 19, 2021

@rtitle
Copy link
Collaborator

rtitle commented May 19, 2021

fiab-start failed, not sure why.. jenkins retest

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #2125 (86438ab) into develop (2271dd9) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2125      +/-   ##
===========================================
- Coverage    75.68%   75.67%   -0.02%     
===========================================
  Files          113      113              
  Lines         8068     8085      +17     
  Branches       145      142       -3     
===========================================
+ Hits          6106     6118      +12     
- Misses        1962     1967       +5     
Impacted Files Coverage Δ
...dinstitute/dsde/workbench/leonardo/http/Boot.scala 0.00% <0.00%> (ø)
.../leonardo/monitor/LeoPubsubMessageSubscriber.scala 78.01% <62.50%> (-0.08%) ⬇️
.../dsde/workbench/leonardo/util/GKEInterpreter.scala 79.48% <83.33%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379a1fe...86438ab. Read the comment docs.

@rtitle rtitle merged commit 19781b3 into develop May 19, 2021
@rtitle rtitle deleted the merged-scala-steward-prs branch May 19, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants