Skip to content

Missing blank line when using POST #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bullestock opened this issue Dec 11, 2017 · 1 comment
Closed

Missing blank line when using POST #4

bullestock opened this issue Dec 11, 2017 · 1 comment

Comments

@bullestock
Copy link

RestClient::request() adds a blank line between headers and request body if the method is GET, but this blank line is needed for other methods too, such as POST.

DaKaZ added a commit that referenced this issue Dec 26, 2017
@DaKaZ
Copy link
Owner

DaKaZ commented Dec 26, 2017

@bullestock thanks for reporting this - its crazy to think that this has been an issue for this long! I verified the format here: https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html and it clearly says there should be a CRLF between the headers and message body. I have fixed this issue.

@DaKaZ DaKaZ closed this as completed Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants