Skip to content

Fix problems resulting from Rust now checking for overflow / underflow #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 8, 2015

Conversation

DaGenix
Copy link
Owner

@DaGenix DaGenix commented Mar 8, 2015

Fix problems resulting from Rust not checking for overflow / underflow:

  • Work around a Rust bug with the overflow / underflow checking as it relates to SIMD types - ICE - tried to get overflow intrinsic for non-int type rust-lang/rust#23037. When "ndebug" is NOT defined (ie: overflow checking is on), use a new "fake-SIMD" type that just simulates all of the SIMD operations using regular tuples of integer types. When "ndebug" is defined (ie: overflow checking is off), use the regular SIMD types.
  • Replace all addition, subtraction, and multiplication that was causing test failures due to overflowing or underflowing with wrapped_add(), wrapped_sub(), or wrapped_mul() as appropriate.
  • Disable optimizations for test builds to help try to make sure that no more overflowing or underflowing operations make it into the code base without using the wrapped_* functions.

Closes #266

DaGenix added a commit that referenced this pull request Mar 8, 2015
Fix problems resulting from Rust now checking for overflow / underflow
@DaGenix DaGenix merged commit e2ba6ea into master Mar 8, 2015
@DaGenix DaGenix deleted the fix-wrappocolypse branch March 8, 2015 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't compile on OSX 10.10
1 participant