Returning error codes from init and receive functions #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abizjak
reviewed
Mar 2, 2021
Could you also add the auction contract to the CI here:
to avoid such issues in the future. |
abizjak
reviewed
Mar 2, 2021
abizjak
reviewed
Mar 2, 2021
|
It looks like we currently won't able to annotate enum fields with |
|
On a second look, derive macro helper attributes are a thing--wonderful. |
abizjak
reviewed
Mar 9, 2021
abizjak
reviewed
Mar 9, 2021
abizjak
reviewed
Mar 9, 2021
- Make it explicit that reject must be non-zero. - Fix the Default of Reject instance to be non-zero. - Remove the need for an allocator in generated code (format! uses an allocator)
This is to avoid confusion between the From instance and the error code that is ultimately displayed to the user. The remaining issue is that the variant tags are still positive since we cannot easily modify them in a derive macro. We'd have to have another attribute macro to achieve this automatically.
abizjak
previously approved these changes
Mar 11, 2021
This brings in i/u128 changes as well.
abizjak
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the changes in the auction smart contract are hard to see because I did a reformatting. But the only "real" changes are that the custom error types derive
Reject(like in the other example contracts), and that it removes fields from theBidTooLowerror, because we don't support enums with fields yet.