Skip to content

[WIP] MicrographSource/Image updates #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

garrettwrong
Copy link
Collaborator

Fix MicrographSource so it can load and operate on EMPIAR experimental data (eg 10061). These datasets often have rectangular shapes.

@garrettwrong garrettwrong self-assigned this Jun 6, 2025
@garrettwrong garrettwrong added bug Something isn't working cleanup labels Jun 6, 2025
@garrettwrong
Copy link
Collaborator Author

After a few attempts I was able to get this down to a somewhat more reasonable change set. I've made a few other things (migrated things I saw towards classmethods) a bit more consistent while I was in there in case more surgery is required down the road.

I still need to hit the filtering methods so that CTF can be applied to these rectangles. etc.

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.57%. Comparing base (c255119) to head (e35b9a5).

Files with missing lines Patch % Lines
src/aspire/image/image.py 75.00% 5 Missing ⚠️
src/aspire/source/micrograph.py 73.68% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1288      +/-   ##
===========================================
- Coverage    90.60%   90.57%   -0.04%     
===========================================
  Files          132      132              
  Lines        14181    14202      +21     
===========================================
+ Hits         12849    12863      +14     
- Misses        1332     1339       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant