Skip to content

Use scipy create_group for SymmetryGroups #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented May 27, 2025

Resolves #1275

Refactors SymmetryGroup's to use scipy create_group. Also adds icosahedral volume to synthetic volumes.

@j-c-c j-c-c self-assigned this May 27, 2025
@j-c-c j-c-c added the cleanup label May 27, 2025
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (486bfbd) to head (4a203cd).

Files with missing lines Patch % Lines
src/aspire/volume/volume_synthesis.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1281      +/-   ##
===========================================
- Coverage    90.60%   90.58%   -0.03%     
===========================================
  Files          132      132              
  Lines        14181    14162      -19     
===========================================
- Hits         12849    12828      -21     
- Misses        1332     1334       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c j-c-c requested a review from garrettwrong June 2, 2025 13:55
garrettwrong
garrettwrong previously approved these changes Jun 3, 2025
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just one question. Code looks a lot lighter, thanks.

@j-c-c j-c-c marked this pull request as ready for review June 3, 2025 15:43
@j-c-c j-c-c requested a review from janden as a code owner June 3, 2025 15:43
@j-c-c
Copy link
Collaborator Author

j-c-c commented Jun 4, 2025

@janden, hold off on reviewing this one. I have to figure out what's going on with this failing "expensive" test.

@j-c-c
Copy link
Collaborator Author

j-c-c commented Jun 5, 2025

Ok @janden, this is ready for review now.

I had to fix the method that globally synchronizes estimates with respect to symmetry group elements. When I work on #1283 that method will be replaced with a general method that handles arbitrary symmetry groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants