Skip to content

Cleanup Duplicate Code #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Cleanup Duplicate Code #1280

wants to merge 6 commits into from

Conversation

j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented May 23, 2025

Resolves #1233

Removes duplicate code found in both src/aspire/utils/coor_trans.py and src/aspire/utils/rotation.py.

Also, I refactored mean_aligned_angular_distance to use the alignment code which now resides in the Rotation class in a way to not change the API. It might make sense to move this function into the Rotation class as well, but it will change the API.

@j-c-c j-c-c self-assigned this May 23, 2025
@j-c-c j-c-c added the cleanup label May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.64%. Comparing base (486bfbd) to head (e0ecc8e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1280      +/-   ##
===========================================
+ Coverage    90.60%   90.64%   +0.03%     
===========================================
  Files          132      132              
  Lines        14181    14124      -57     
===========================================
- Hits         12849    12802      -47     
+ Misses        1332     1322      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c j-c-c requested a review from garrettwrong June 2, 2025 13:37
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor string update and quick questions, thanks.

@j-c-c j-c-c marked this pull request as ready for review June 3, 2025 15:43
@j-c-c j-c-c requested a review from janden as a code owner June 3, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants