Skip to content

IRLS #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

IRLS #1263

wants to merge 13 commits into from

Conversation

j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Apr 28, 2025

Port of the common lines method using IRLS.

@j-c-c j-c-c added the enhancement New feature or request label Apr 28, 2025
@j-c-c j-c-c self-assigned this Apr 28, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.94521% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.71%. Comparing base (845a750) to head (92c14f7).

Files with missing lines Patch % Lines
src/aspire/abinitio/commonline_lud.py 86.95% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1263      +/-   ##
===========================================
+ Coverage    90.63%   90.71%   +0.08%     
===========================================
  Files          132      133       +1     
  Lines        14174    14298     +124     
===========================================
+ Hits         12846    12970     +124     
  Misses        1328     1328

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c j-c-c changed the title [WIP] IRLS IRLS May 21, 2025
@j-c-c j-c-c requested a review from garrettwrong May 21, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettwrong garrettwrong Awaiting requested review from garrettwrong garrettwrong is a code owner

@janden janden Awaiting requested review from janden janden will be requested when the pull request is marked ready for review janden is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@j-c-c j-c-c

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-c-c