Feature/wireframe #535
Open
Feature/wireframe #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MouawiaElkhalifa
added
the
Needs Review
MouawiaElkhalifa
requested review from
jenny-alexander,
halilibrahimcelik and
SallyMcGrath
|
Hi, Could you please check my pull request Feature/wireframe #535 |
jeremycward
added
the
Review in progress
jeremycward
reviewed
May 17, 2025
jeremycward
reviewed
May 17, 2025
| } | ||
|
|
||
| main > *:first-child { |
There was a problem hiding this comment.
If I understand this, 'any' first-child will be column span 2 . Is this not a bit dangerous ?
jeremycward
reviewed
May 17, 2025
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| flex: 1; | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; |
There was a problem hiding this comment.
why not use named grid template colulmns ? This would make it clearer
https://css-tricks.com/snippets/css/complete-guide-grid/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.