Skip to content

Control form #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Control form #533

wants to merge 7 commits into from
+56 −9

Conversation

MouawiaElkhalifa
Copy link

Learners, PR Template

Self checklist

  • [ YES] I have committed my files one by one, on purpose, and for a reason
  • [ YES] I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • [YES] I have tested my changes
  • [ YES] My changes follow the style guide
  • [YES ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@netlify Netlify
Copy link

netlify bot commented May 17, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 4c670b7
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/682873736c5e380008877a8e
😎 Deploy Preview https://deploy-preview-533--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@MouawiaElkhalifa MouawiaElkhalifa added the Needs Review Participant to add when requesting review label May 17, 2025
@MouawiaElkhalifa
Copy link
Author

PHi could you please check my coding for form-controls

@MouawiaElkhalifa MouawiaElkhalifa mentioned this pull request May 17, 2025
Open
@jeremycward jeremycward added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 17, 2025
jeremycward
jeremycward reviewed May 17, 2025
View reviewed changes
Wireframe/index.html
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the file you reverted back to original, is it ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is

jeremycward
jeremycward approved these changes May 17, 2025
View reviewed changes
Copy link

@jeremycward jeremycward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@jenny-alexander jenny-alexander removed their request for review May 18, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremycward jeremycward jeremycward approved these changes

@halilibrahimcelik halilibrahimcelik Awaiting requested review from halilibrahimcelik

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MouawiaElkhalifa @jeremycward