Skip to content

ITP JAN 2025 LONDON | ELFREDAH KEVIN-ALERECHI | DATA GROUP | SPRINT 3 #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Elfredah
Copy link

@Elfredah Elfredah commented Apr 3, 2025

Complete the task list below this message.
If your PR is rejected, check the task list.

-->

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Elfredah
Copy link
Author

@halilibrahimcelik
Please, can you help me review my pull request

@halilibrahimcelik halilibrahimcelik self-requested a review April 12, 2025 11:11
@halilibrahimcelik halilibrahimcelik added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Apr 12, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Apr 13, 2025

@halilibrahimcelik This branch seems to contain all the project files.
Elfredah has recently created two separate PRs for the Alarm Clock Project and the Quote Generator Quote Project.

I just want to let you know that I will be reviewing those two PRs.

@Elfredah
Copy link
Author

I am resubmiting because I missed the ITP JAN 2024 deadline @cjyuan

@cjyuan
Copy link
Contributor

cjyuan commented May 19, 2025

https://codeyourfutur-yov6609.slack.com/docs/T07MCNDRDHV/F07QX9AA3ND

There are some steps described in the PR essentials in the above Slack Canvas that you can take to improve your PR. Can you try those steps first? It could help us speed up the review process.

@cjyuan
Copy link
Contributor

cjyuan commented May 19, 2025

Your repo is 2 commits behind CYF's repo. You may want to update your repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants