[ENG-8054] Check and rewrite unittesting where is needed #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be problems with signature on some requests (for example _complete_multipart_upload )
…onfig(signature_version='s3v4'), trying to find for others requests, for example for '_abort_chunked_upload' got for now 2025-05-15T13:21:20.637311375Z waterbutler.core.exceptions.UploadError: 403, {"response": "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>SignatureDoesNotMatch</Code><Message>The request signature we calculated does not match the signature you provided. Check your key and signing method ...c 4f 41 44</CanonicalRequestBytes><RequestId>42Q4F2F8SDWMFVHX</RequestId><HostId>osG5j/y2tPRMoIelFMON/qSvV+oPZk7EvwcVAMdTlbCnckHJ66LRAInG5vg6dCne7wrmZtJsRdBMyi0yN1w1Bux+zoQ7MEWG</HostId></Error>"}
…it to be it more clear )
…eviously for 'get_folder_metadata'
…o test it out from UI(front-end side)), add additional casting for folders removal
…ataError: 404, None , for now 'latest-published' produce error TODO: maybe that fix is needed to be updated somehow
… positional argument: 'raw' for unit tests
…': No...upload': None}
…api/v1/datasets/18/versions/%253Alatest?key=wrote+harry+potter with params {'key': 'wrote harry potter'}. Not making request. Go fix your test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8054
Purpose
WB has a bunch of failing tests. Let's fix 'em!
If the cause of a test failure turns out to need a big fix, we can create another ticket to track it.
Changes
Changing unit testing to be passed for 3.13 python (create the branch from the following PR branch to keep changings
#434
)
Side effects
await provider._check_region()stuck for my though on meeting session the execution flow goes further from Fitz side ).while trying to run tests separately they are passed .
python -m poetry run pytest tests/tasks/test_serialization.py::test_non_path_objects_serialize_normally
python -m poetry run pytest tests/server/api/v1/test_provider.py::TestProviderHandlerFinish::test_logging_direct_partial_download_file
maybe it is also my local issue, though maybe some changings related MainThread are implemented in any another ticket.
QA Notes
Deployment Notes