[ENG-7962] Fix User Setting Response Payload async mailchimp perference change issues #11136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
changed the title
Johnetordoff
force-pushed
the
fix-user-setting-return
branch
from
628f9ee to
c43b4ee
Compare
Johnetordoff
force-pushed
the
fix-user-setting-return
branch
from
3727127 to
99bf004
Compare
Johnetordoff
commented
May 9, 2025
| @@ -602,10 +599,6 @@ def impute_names(**kwargs): | |||
| return auth_utils.impute_names(name) | |||
|
|
|||
|
|
|||
| def update_osf_help_mails_subscription(user, subscribe): | |||
There was a problem hiding this comment.
I don't see why this exists and there's multiple tests for it, so I'm just removing it to cut down on the number of tests.
Johnetordoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Correct issues where PATCH responses wouldn't show preferences as updated due to async mailchimp task execution. Overrides instance model to return changed value, even though db value is unchanged until mailchimp confirms.
Changes
update_osf_help_mails_subscriptionbecause it's not used, but tested.QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-7962