[ENG-7716] Allow for reinstatement of previous preprint versions (with date uploaded) via the admin app

[antkryt]

Purpose

Add "Create new version 1" button on admin UI

Changes

• Add button to admin UI
• Extend existing preprint versioning functionality
• Move permission validation logic from serializer to model level to keep everything in one place
  • add required_permission decorator (with ignore_permission functionality) that checks if user has enough permission to call method

Screencast.from.2025-04-22.14-43-05.webm

QA Notes

Expected behavior:

1. Admin goes the preprint admin page
2. Clicks "Create new version 1", a modal asking to choose date will be displayed
3. If date is valid and file versions exists:
   • a new version 1 will be created
   • admin user will be redirected to v1
   • optionally, admin user can make new preprint published by clicking "Make published" button

(!) Preprint guid should point to the latest version, not the newly created one.
(!) Admin should be able to create new versions of a preprint even if they are not a contributor.

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-7716

[antkryt]

Alternatives:

1. Add admin user to contributors to create new version and remove after it
2. Create incomplete new preprint version (do not call PreprintSeriazlier.update() method) and update only primary_file for new preprint. User should be able to fill all the other fields with "Edit" button on the osf website

Both requires additional actions from user, but will make this PR ~2x smaller

[brianjgeiger]

@antkryt Looks like there's a failed test.

=========================== short test summary info ============================
FAILED admin_tests/preprints/test_views.py::TestPreprintReVersionView::test_admin_user_can_add_new_version_one - assert 1 == 2
 +  where 1 = len(<GuidMixinQuerySet [<Preprint: Preprint object (868)>]>)
 +    where <GuidMixinQuerySet [<Preprint: Preprint object (868)>]> = <bound method Preprint.get_preprint_versions of <Preprint: Preprint object (868)>>()
 +      where <bound method Preprint.get_preprint_versions of <Preprint: Preprint object (868)>> = <Preprint: Preprint object (868)>.get_preprint_versions
=== 1 failed, 2813 passed, 42 skipped, 20469 warnings in 1501.92s (0:25:01) ====

[brianjgeiger]

Why are you going through the API for this instead of just using the Preprint model to make the changes? It seems as though it would save you a lot of trouble if you just made the changes directly via the model. The Admin app shouldn't interact with the API.

[antkryt]

The Preprint.create_version documentation states:
"... The API, specifically the PreprintCreateVersionSerializer, must call .update() to fully finalize the creation of the new preprint version object."

If I don't use the serializer, I would need to manually call around 15 Preprint.set_ methods, each with ignore-permission=True. Also, if the data_to_update dictionary structure or PreprintCreateVersionSerializer.update logic ever changes in the future, it may easily break this feature.

So, nothing really changes if I use PreprintCreateVersionSerializer (API) or not because of the create_version() function

[brianjgeiger]

I see.