Fixed issue in notebook with TenosrArray bool selection #165
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
||
| # Test Series of TensorDType selection with TensorArray | ||
| # Currently fails due to Pandas not recognizing as bool index GH#162 | ||
| with self.assertRaises(Exception): |
There was a problem hiding this comment.
Looking into a fix upstream, I think pandas should be able to recognize as a bool index
| @@ -35,6 +35,7 @@ class TensorDtype(pd.api.extensions.ExtensionDtype): | |||
| """ | |||
| Pandas data type for a column of tensors with the same shape. | |||
| """ | |||
| base = None | |||
There was a problem hiding this comment.
What does this do? Should this change be repeated on the dtypes for span arrays?
There was a problem hiding this comment.
I'm not sure, I can't find any documentation for it. It's in some extension types and only set to something for a couple. Without it, there is an error in a cython function when using integer as index. I'll followup with a question to the mailing list and try to add document or a fix upstream. It doesn't seem to be needed any other place, so I wouldn't add to other arrays just yet.
I made #166 to track investigation
|
Thanks @frreiss, I'll work on an update then merge. |
No description provided.