Deprecate namespaces declared with module keyword #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CC972
force-pushed
the
deprecate-namespaces-declared-with-module-keyword
branch
from
265e593 to
92f6d4f
Compare
|
I'm presuming we didn't want this to be configurable? Which I do agree with, doesn't seem worth adding an option to keep the existing behavior as this really should be 100% compatible with anyones current workflow unless they are somehow relying on this deprecated syntax. |
Co-authored-by: Ashley Claymore <[email protected]>
CC972
commented
Mar 9, 2023
| return node.modifiers !== modifiers | ||
| || node.name !== name | ||
| || node.body !== body | ||
| ? update(createModuleDeclaration(modifiers, name, body, node.flags | NodeFlags.Namespace), node) |
There was a problem hiding this comment.
As discussed with Titian, we should be able to replace this final return with simply:
return update(createModuleDeclaration(modifiers, name, body, node.flags | NodeFlags.Namespace), node)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #