You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
crates-index-diff 0.11.2 bumped git-repository to major version 0.24, but since Index::repository returnsgit_repository::Repository, this change is backwards-incompatible.
fncount_versions(rep:&git_repository::Repository){ ...}fnmain(){let index = crates_index_diff::...;count_versions(index.repository());}
which failed to build after running cargo update with:
error[E0308]: arguments to this function are incorrect
--> src/incremental.rs:339:18
|
339 | exist += count_versions(index.repository(), &e)?;
| ^^^^^^^^^^^^^^ ------------------ -- expected struct `git_repository::object::tree::EntryRef`, found struct `git_repository::object::tree::iter::EntryRef`
| |
| expected struct `git_repository::Repository`, found struct `git_repository::types::Repository`
|
= note: expected reference `&git_repository::Repository`
found reference `&git_repository::types::Repository`
= note: perhaps two different versions of crate `git_repository` are being used?
= note: expected reference `&git_repository::object::tree::EntryRef<'_, '_>`
found reference `&git_repository::object::tree::iter::EntryRef<'_, '_>`
= note: perhaps two different versions of crate `git_repository` are being used?
The text was updated successfully, but these errors were encountered:
I will try to be more careful with that. I got a bit over-reliant on cargo smart-release which takes care of version bumps, but only based on commit messages that do indicate something is breaking. Thus, when upgrading git-repository it was upon me to recognize this as breaking change, but that didn't happen.
crates-index-diff 0.11.2
bumpedgit-repository
to major version 0.24, but sinceIndex::repository
returnsgit_repository::Repository
, this change is backwards-incompatible.In particular, I hit this in a crate with:
which failed to build after running
cargo update
with:The text was updated successfully, but these errors were encountered: