Add type hints to oncebitten, prober, punisher, rand

[janga1997]

#808
Same error as #860 , mypy cannot infer type for empty containers. See here.

[drvinceknight]

Same error as #860 , mypy cannot infer type for empty containers. See here.

Ok that's good to know. I'm not sure what the best way to deal with this is...

[janga1997]

@drvinceknight Apparently a simple workaround is to add the comment
# type: List[Action]
we can explicitly annotate variables with these type of comments in mypy.
I believe this is the best solution right now, as mypy has no plans to fix this issue.

[drvinceknight]

I believe this is the best solution right now, as mypy has no plans to fix this issue.

It looks good to me! Nice find :)

[drvinceknight]

@meatballs Can you merge this PR? And a couple other type hint PRs too which have been reviewed?

Hi @janga1997 we all keep an eye on the PRs. Sorry it's taking us a little while to merge them but there's no need to ping us. We just all happen to be busy right now. They will be merged as soon as possible :)

[janga1997]

@drvinceknight Sorry for the trouble. Won't happen again.

[drvinceknight]

No trouble at all. All these contributions are awesome. Just a shame they're coming at a time when we seem to all be busy :D

[janga1997]

@drvinceknight I understand. And all the core maintainers have full time jobs.
And you are working while traveling.
I'm just a bored college junior here :-)

[janga1997]

@meatballs Why are the errors showing up after merging master? Is it anything of consequence?

[meatballs]

No, it's just that I merged it before Travis had run again, so github thinks there was a problem