Skip to content

Add type hints to apavlov #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 10, 2017
Merged

Add type hints to apavlov #846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2dee6f3
Add type hints to apavlov
janga1997 Feb 2, 2017
cf8d76c
Merge branch 'master' of https://github.com/Axelrod-Python/Axelrod in…
janga1997 Feb 5, 2017
11ed751
Add apavlov to type_tests
janga1997 Feb 5, 2017
8d658ac
Merge branch 'master' into typeHint-apavlov
janga1997 Feb 5, 2017
c821551
Merge branch 'master' into typeHint-apavlov
janga1997 Feb 5, 2017
9383dee
Merge branch 'master' into typeHint-apavlov
janga1997 Feb 5, 2017
2d2d745
Merge branch 'master' into typeHint-apavlov
janga1997 Feb 7, 2017
c817c85
Fix None-str issue
janga1997 Feb 9, 2017
a9257d2
Merge branch 'typeHint-apavlov' of https://github.com/janga1997/Axelr…
janga1997 Feb 9, 2017
b0fa87f
Merge branch 'master' into typeHint-apavlov
janga1997 Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions axelrod/strategies/apavlov.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from axelrod.actions import Actions

from axelrod.actions import Actions, Action
from axelrod.player import Player

C, D = Actions.C, Actions.D
Expand Down Expand Up @@ -26,11 +27,11 @@ class APavlov2006(Player):
'manipulates_state': False
}

def __init__(self):
def __init__(self) -> None:
super().__init__()
self.opponent_class = None
self.opponent_class = ""

def strategy(self, opponent):
def strategy(self, opponent: Player) -> Action:
# TFT for six rounds
if len(self.history) < 6:
return D if opponent.history[-1:] == [D] else C
Expand Down Expand Up @@ -93,11 +94,11 @@ class APavlov2011(Player):
'manipulates_state': False
}

def __init__(self):
def __init__(self) -> None:
super().__init__()
self.opponent_class = None
self.opponent_class = ""

def strategy(self, opponent):
def strategy(self, opponent: Player) -> Action:
# TFT for six rounds
if len(self.history) < 6:
return D if opponent.history[-1:] == [D] else C
Expand Down
1 change: 1 addition & 0 deletions type_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/alternato
mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/ann.py
mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/appeaser.py
mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/averagecopier.py
mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/apavlov.py
mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/axelrod_second.py
mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/backstabber.py
mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/better_and_better.py
Expand Down