[#1370] Remove some tests from test_meta.py #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some tests that do not target specific strategy behaviors and can change when new strategies are added.
|
This all looks fine @marcharper, thanks for doing it. I thought #1374 could be nice to have so we know that at least the strategies don't return nonsense. As far as I know we don't have a generic test like that for all strategies. |
Not sure if this is overkill @marcharper, just thought it could be worth having.
|
This looks good 👍 |
drvinceknight
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some tests that do not target specific strategy behaviors and can change when new strategies are added.